types(create): fix handling of nested objects typed as interfaces

[vkarpov15]

Summary

#16362 is not an issue with strings vs objectids, it's an issue with how nested object types vs nested interfaces are handled by create() typing. In #16362, Nested is an interface not an object type, and interfaces are not assignable to Record<string, unknown> for TypeScript internal reasons. Probably because interfaces can be augmented (multiple definitions of the same interface add properties).

Examples

[Copilot]

Pull request overview

This PR updates Mongoose’s TypeScript Model.create() input casting types to correctly handle nested subdocuments whose types are declared as interfaces (as in #16362), and adds a corresponding type-level test.

Changes:

• Adjust CreateObjectWithExtraKeys<T> to accept both interface-typed values and “extra key” object-literals used in create inputs.
• Add a type test covering nested populated doc creation via create().

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File	Description
types/models.d.ts	Updates the helper type used by ApplyBasicCreateCasting for create() inputs to better support nested interface-typed objects.
test/types/create.test.ts	Adds a type test scenario for nested populated doc creation inputs.

[AbdelrahmanHafez]

Probably worth addressing Copilot's comment, otherwise LGTM

[hasezoey]

Looks good to me and fixes the issue in typegoose-testing.
I also agree that the Copilot comment should be addressed.