fix getting started guide callbacks #1909

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@hansent
hansent commented Jan 30, 2014

the find and save callbacks were in fact logging to console only if there was an error, rather than the other way around as described in the text.

@hansent hansent fix getting started guide callbacks
the find and save callbacks were in fact logging to console only if there was an error, rather than the other way around as described in the text.
84f5231
@aheckmann
Collaborator

the docs state we logged the kittens to the console, not the errors.

@aheckmann aheckmann closed this Feb 22, 2014
@hansent
hansent commented Feb 22, 2014

Right...except the kittens don't actually get logged, unless their is an error...

@aheckmann aheckmann reopened this Feb 22, 2014
@aheckmann
Collaborator

ah the {}

@hansent
hansent commented Feb 22, 2014

:)

You don't have to merge the pull request if you just want to add {} after the if yourself instead. Just wanted to point it out. Was showing it to students, and they were confused by it not printing anything.

@aheckmann aheckmann added a commit that referenced this pull request Feb 23, 2014
@aheckmann aheckmann docs; make the code runnable 004a9e7
@aheckmann
Collaborator

fixed it. thanks!

@aheckmann aheckmann closed this Feb 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment