Force $(days|months|years)_being_processed to an array. #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if these options were not set (e.g. when generating a single day's sitemap), it would return the bool `false`, which is not countable. In PHP versions 7.1-, PHP would proceed with `count` by returning 1. This would result in the logic checks to true unexpectedly, leading in the entire sitemap being rebuilt for every modified post. In PHP version 7.2, this throws a warning for usage of `count` on a non-countable, so this change also improves 7.2 compatability.
|
LGTM, I like that you split up the whitespace changes into a separate commit. |
|
Nice job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if these options were not set (e.g. when generating a single day's sitemap), it would return the bool
false, which is not countable.In PHP versions 7.1-, PHP would proceed with
countby returning 1. This would result in the logic checks to true unexpectedly, leading in the entire sitemap being rebuilt for every modified post.In PHP version 7.2, this throws a warning for usage of
counton a non-countable, so this change also improves 7.2 compatibility.