Kill full sitemap cron generation #99

Open
wants to merge 3 commits into
from

Projects

None yet

2 participants

@mjangda
Member
mjangda commented Jan 4, 2017

For really large datasets, this ends up in a flood of thousands of cron events that can
slow down or completely disable a site.

Fixes #81

@mjangda
Member
mjangda commented Jan 4, 2017 edited

This keeps the ongoing cron-based updates (triggered every 15 minutes) although can be replaced with your own system, see https://github.com/Automattic/msm-sitemap/blob/master/wpcom-helper.php#L3

@pkevan
Contributor
pkevan commented Jan 9, 2017

Wouldn't this change result in lots of queued crons, but no action to execute them?

msm_cron_generate_sitemap_for_year_month_day should follow something similar to https://github.com/Automattic/msm-sitemap/blob/master/vipgo-helper.php#L8 unless I've misread the changeset.

mjangda added some commits Jan 4, 2017
@mjangda mjangda Kill full sitemap cron generation
For really large datasets, this ends up in a flood of thousands of cron events that can
slow down or completely disable a site.

Fixes #81
515ada8
@mjangda mjangda rm vipgo-helper
We no longer need to disable the cron and add a workaround since the
initial cron stuff no longer exists.
4321df6
@mjangda mjangda Restore generate_sitemap_for_year_month_day
We need something to actually trigger the scheduled cron events
dc38121
@mjangda
Member
mjangda commented Jan 9, 2017

Wouldn't this change result in lots of queued crons, but no action to execute them?

Yep, great catch. I've restored the relevant code. A few other things we probably need to do:

  • Update tests.
  • Make sure wpcom-helper.php doesn't need any more changes.
  • Remove any related options from other files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment