Proposed fix for #404

[soatok]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Closes #404 .

How to test the changes in this Pull Request:

1. Create a blog with more than 30 test posts, with 10 displayed in the list block.
2. Verify that you can press the button more than twice without the block disappearing.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[dkoo]

@soatok Thanks for the proposed fix—we'll review and test this shortly.

[dkoo]

@soatok Thanks for the proposed fix! I believe you've correctly identified the cause of the issue here, but there are a few things we'd want to implement in a fix:

1. We'd need to implement the fix in both AMP JS (the file you've edited here) and non-AMP JS (/src/blocks/homepage-articles/view.js). You can test the non-AMP JS by disabling AMP on the particular page, by deactivating the AMP plugin, or setting the plugin to Transitional mode and viewing the base permalink (without /amp suffix).
2. We'd like to refactor the AMP JS to avoid the use of new URL, which is not supported by IE11 or below. This would be an improvement over our current code, which uses the URL class in AMP JS while relying on plain strings in non-AMP JS.
3. We'd need to ensure that the custom REST route still works correctly if not passed the exclude_ids param, or if the param is an empty array. So this might mean selectively retaining the page param and/or fixing its implementation on the PHP side.

Would you like to try to implement the above? If not, we're happy take over this fix (with props to you for identifying the solution). Thanks again!

[soatok]

Would you like to try to implement the above? If not, we're happy take over this fix (with props to you for identifying the solution). Thanks again!

Unfortunately I'm a bit triple-booked at work right now. Please feel free to take over this fix. Thanks!

[dkoo]

Rather than messing with the fork, I'm closing this PR in favor of #672.