Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Design Wizard: Theme Mod Controls #433

Merged
merged 14 commits into from Feb 26, 2020
Merged

Conversation

jeffersonrabb
Copy link
Contributor

@jeffersonrabb jeffersonrabb commented Feb 10, 2020

All Submissions:

Changes proposed in this Pull Request:

Adds a 2nd tab to the Site Design Wizard with the Theme Options.

How to test the changes in this Pull Request:

  1. Switch to this branch
  2. Navigate to Site Design > Settings
  3. Change the different options and check if they are being applied.
  4. Check the Customizer if the 2 matches.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@jeffersonrabb jeffersonrabb self-assigned this Feb 10, 2020
@thomasguillot thomasguillot added the [Status] Needs Review The issue or pull request needs to be reviewed label Feb 24, 2020
@jeffersonrabb jeffersonrabb marked this pull request as ready for review February 25, 2020 16:22
Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One missing default value, plus some tiny linting nitpicks

assets/wizards/site-design/views/theme-mods/index.js Outdated Show resolved Hide resolved
@adekbadek adekbadek added [Status] Approved The pull request has been reviewed and is ready to merge [Status] Needs changes or feedback The issue or pull request needs action from the original creator and removed [Status] Needs Review The issue or pull request needs to be reviewed [Status] Approved The pull request has been reviewed and is ready to merge labels Feb 25, 2020
@jeffersonrabb
Copy link
Contributor Author

plus some tiny linting nitpicks

Linting errors fixed in 545ddb0

@jeffersonrabb
Copy link
Contributor Author

@thomasguillot do you think this screen should have a preview feature?

@thomasguillot
Copy link
Contributor

@thomasguillot do you think this screen should have a preview feature?

@jeffersonrabb the "Advanced settings" button currently acts as a preview since it takes you to the customiser.

I think once the Site Design is fully complete (all settings moved to the wizard) I will consider removing the customiser button in favour of a preview.

@adekbadek adekbadek added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs changes or feedback The issue or pull request needs action from the original creator labels Feb 26, 2020
@jeffersonrabb jeffersonrabb merged commit ee98a09 into master Feb 26, 2020
@jeffersonrabb jeffersonrabb deleted the add/theme-mod-controls branch February 26, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants