New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude concatenation for js files which have inline js added #42

Merged
merged 2 commits into from Oct 19, 2018

Conversation

Projects
None yet
2 participants
@dchymko
Copy link
Contributor

dchymko commented Oct 18, 2018

Description

When certain js files are run through the existing concatenation on VIP Go, some are not properly rendered which breaks things in the Gutenberg editor. This fix skips concatenation for any files that add line script via wp_add_inline_script()

Pros

Gutenberg works

Cons

Performance can be slightly affected when less files are concatenated

Steps to Test

See Automattic/vip-go-mu-plugins#985

Exclude concatenation for js files which have inline js added via wp_…
…add_inline_script(). This fixes issues with the Gutenberg editor not loading correctly.

@dchymko dchymko self-assigned this Oct 18, 2018

@mjangda
Copy link
Member

mjangda left a comment

LGTM.

@mjangda mjangda merged commit 3562fc3 into master Oct 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mjangda mjangda deleted the fix/exclude-inline-js-concatenation branch Oct 19, 2018

mjangda added a commit that referenced this pull request Oct 29, 2018

Revert "Merge pull request #42 from Automattic/fix/exclude-inline-js-…
…concatenation"

This reverts commit 3562fc3, reversing
changes made to 10025c4.

Removing this so we can push out our stats changes first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment