Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

gyp not building with jpeg/gif support #195

Open
logicalparadox opened this Issue · 9 comments

4 participants

@logicalparadox

It looks like with_jpeg/gif is hardcoded as false in the binding.gyp file. Given the bugfixes already applied to work with node 0.8.x,'s version of v8, it would be great if this integrated with the configure file that you started so we could use the full functionality of this module. Any idea on when this will be available?

I don't know enough about gyp to be able to open a pull request for this. If you don't have time enough to implement or could point me to a project or docs that implement this type of configuration, or provide more specifics on what it is you were in the process of doing, I would be more than happy to give it a go.

@c-spencer

The binding.gyp doesn't do detection of jpeg/gif yet, but you can edit the binding.gyp manually and set them to true.

@TooTallNate
Owner

With node-gyp you can do $ node-gyp configure --with-jpeg --with-gif && node-gyp build, and once TJ publishes to npm you can do $ npm install canvas --with-jpeg --with-gif.

The problem with that is that you can't really specify those flags in the "dependencies" section of your package.json file, so some sort of auto-detection is needed.

@tj
tj commented

yeah im waiting on us getting in some way to script ^ before releasing

@c-spencer

Would this work?

AllYearbooks@9c13c23

I'm not sure whether ./ will always point into the right directory for running the script, though.

@tj
tj commented

LGTM, I dont know much about gyp but assuming that funky syntax actually works

@logicalparadox

I have been doing what @TooTallNate suggested for now, but that other approach looks good too. Shall I implement and open PR (as AllYearbooks did not?

@TooTallNate
Owner

It would break Windows so we need to default them to false, and then run those scripts in a conditional block where OS!="win".

@tj
tj commented

right, stupid windows

@c-spencer

Updated, it's currently mixed in with pango support though, not sure whether you want that upstream just yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.