From f8de2fa967b04c146967cd6b6d8096bfd31f0cd6 Mon Sep 17 00:00:00 2001 From: Rosga Date: Fri, 15 Mar 2019 12:36:23 +0200 Subject: [PATCH 1/2] Fixed build for electron 5 --- src/Backends.cc | 2 +- src/Backends.h | 2 +- src/backend/ImageBackend.cc | 2 +- src/backend/ImageBackend.h | 2 +- src/backend/PdfBackend.cc | 2 +- src/backend/PdfBackend.h | 2 +- src/backend/SvgBackend.cc | 2 +- src/backend/SvgBackend.h | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/Backends.cc b/src/Backends.cc index 6490ab6e0..a248860f8 100644 --- a/src/Backends.cc +++ b/src/Backends.cc @@ -6,7 +6,7 @@ using namespace v8; -void Backends::Initialize(Handle target) { +void Backends::Initialize(Local target) { Nan::HandleScope scope; Local obj = Nan::New(); diff --git a/src/Backends.h b/src/Backends.h index 55b663c15..dbea053ce 100644 --- a/src/Backends.h +++ b/src/Backends.h @@ -6,5 +6,5 @@ class Backends : public Nan::ObjectWrap { public: - static void Initialize(v8::Handle target); + static void Initialize(v8::Local target); }; diff --git a/src/backend/ImageBackend.cc b/src/backend/ImageBackend.cc index dfae3dd13..fa0689b63 100644 --- a/src/backend/ImageBackend.cc +++ b/src/backend/ImageBackend.cc @@ -57,7 +57,7 @@ void ImageBackend::setFormat(cairo_format_t _format) { Nan::Persistent ImageBackend::constructor; -void ImageBackend::Initialize(Handle target) { +void ImageBackend::Initialize(Local target) { Nan::HandleScope scope; Local ctor = Nan::New(ImageBackend::New); diff --git a/src/backend/ImageBackend.h b/src/backend/ImageBackend.h index cb2b4e917..f68dacfdb 100644 --- a/src/backend/ImageBackend.h +++ b/src/backend/ImageBackend.h @@ -20,7 +20,7 @@ class ImageBackend : public Backend int32_t approxBytesPerPixel(); static Nan::Persistent constructor; - static void Initialize(v8::Handle target); + static void Initialize(v8::Local target); static NAN_METHOD(New); const static cairo_format_t DEFAULT_FORMAT = CAIRO_FORMAT_ARGB32; }; diff --git a/src/backend/PdfBackend.cc b/src/backend/PdfBackend.cc index 173103ed6..2b72a8a58 100644 --- a/src/backend/PdfBackend.cc +++ b/src/backend/PdfBackend.cc @@ -36,7 +36,7 @@ cairo_surface_t* PdfBackend::recreateSurface() { Nan::Persistent PdfBackend::constructor; -void PdfBackend::Initialize(Handle target) { +void PdfBackend::Initialize(Local target) { Nan::HandleScope scope; Local ctor = Nan::New(PdfBackend::New); diff --git a/src/backend/PdfBackend.h b/src/backend/PdfBackend.h index 4d334c9d2..03656f500 100644 --- a/src/backend/PdfBackend.h +++ b/src/backend/PdfBackend.h @@ -19,6 +19,6 @@ class PdfBackend : public Backend static Backend *construct(int width, int height); static Nan::Persistent constructor; - static void Initialize(v8::Handle target); + static void Initialize(v8::Local target); static NAN_METHOD(New); }; diff --git a/src/backend/SvgBackend.cc b/src/backend/SvgBackend.cc index de792f4c8..54916ee97 100644 --- a/src/backend/SvgBackend.cc +++ b/src/backend/SvgBackend.cc @@ -38,7 +38,7 @@ cairo_surface_t* SvgBackend::recreateSurface() { Nan::Persistent SvgBackend::constructor; -void SvgBackend::Initialize(Handle target) { +void SvgBackend::Initialize(Local target) { Nan::HandleScope scope; Local ctor = Nan::New(SvgBackend::New); diff --git a/src/backend/SvgBackend.h b/src/backend/SvgBackend.h index b2a6be655..6377b438b 100644 --- a/src/backend/SvgBackend.h +++ b/src/backend/SvgBackend.h @@ -19,6 +19,6 @@ class SvgBackend : public Backend static Backend *construct(int width, int height); static Nan::Persistent constructor; - static void Initialize(v8::Handle target); + static void Initialize(v8::Local target); static NAN_METHOD(New); }; From 2896465c006f06f931c1e3b5c3e62e23af47eeff Mon Sep 17 00:00:00 2001 From: Rosga Date: Fri, 15 Mar 2019 12:44:35 +0200 Subject: [PATCH 2/2] Updated changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9ec903e47..142ce30ac 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ project adheres to [Semantic Versioning](http://semver.org/). ### Changed ### Added ### Fixed +* Fix electron 5 and node 12 compatibility 2.4.0 ==================