Image mime data tracking #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of mime API behind cairo version conditional.
… data memory handling.
| @@ -58,6 +53,11 @@ | |||
| proto->SetAccessor(String::NewSymbol("height"), GetHeight); | |||
| proto->SetAccessor(String::NewSymbol("onload"), GetOnload, SetOnload); | |||
| proto->SetAccessor(String::NewSymbol("onerror"), GetOnerror, SetOnerror); | |||
| #if CAIRO_VERSION_MINOR >= 10 | |||
| proto->SetAccessor(String::NewSymbol("dataMode"), GetDataMode, SetDataMode); | |||
| constructor->Set(String::NewSymbol("MODE_IMAGE"), Number::New(1)); | |||
There was a problem hiding this comment.
we should use the enums here instead of the literal value
|
looks good! my gut feeling is that this stuff is a bit out of scope for the module but if you guys are finding it useful likely someone else will too |
|
Thanks for the merge. Yeah this is definitely near the edge of where the module functionality should be, but kind of needed for building PDFs efficiently. I've introduced error handling for jpeg decoding and some colour space detection in my fork, which fixes a lot of the issues relating to crashing on random images. (https://github.com/c-spencer/node-canvas) Will probably pull request next week, or you can pull across. Just making it a bit more robust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final (for now ;)) and largest pull request, adds Mime data options to Image. This means that the cairo pdf backend can directly embed source jpegs.
This commit should also make drawImage work on cairo < 1.10 (#52) as to keep mime data tracked, the intermediate surface used had to be eliminated.