Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Changed the node-gyp build to use pkg-config #212

Merged
merged 1 commit into from Feb 15, 2013

Conversation

Projects
None yet
5 participants
Contributor

jhurliman commented Sep 5, 2012

This fixes the build on OSX when installing the dependencies through macports, which puts things in /opt/local

Changed the node-gyp build to use pkg-config
This fixes the build on OSX when installing the dependencies through macports, which puts things in /opt/local

Cairo usually already links with libpixman-1, so no need to query it again I think. At least pkg-config cairo --libs lists -lpixman-1 here.

That said, I ran into this same issue on OpenBSD and would like to see this merged.

Contributor

RandomEtc commented Oct 14, 2012

👍

I've had troubles linking the homebrew version of cairo on Mac OS so I can't install 0.13.1 (or current master) cleanly without this patch. With this patch everything builds successfully and the tests all pass, and the Cairo headers from /usr/X11/include/cairo are used.

Contributor

jhurliman commented Oct 19, 2012

bump

Contributor

tj commented Oct 19, 2012

gah unix structure is a mess haha.. i'll try this in a bit

👍 Using SmartOS and pkgin it appears the libraries are all installed in /opt/local/lib as well, and node-canvas fails. This would be really good to have.

Contributor

jhurliman commented Dec 27, 2012

Friendly ping checking on the status of this

Contributor

jhurliman commented Jan 24, 2013

Ping

Contributor

jhurliman commented Feb 15, 2013

Several issues have been opened referencing problems with node-canvas and macports installation on canvas. I've been running this patch in production for several months now; I think it would address a lot of the install frustration with node-canvas.

tj added a commit that referenced this pull request Feb 15, 2013

Merge pull request #212 from jhurliman/patch-1
Changed the node-gyp build to use pkg-config

@tj tj merged commit e7a2bb8 into Automattic:master Feb 15, 2013

Contributor

jhurliman commented Feb 25, 2013

Awesome! Can we get a version bump and npm publish?

Contributor

tj commented Feb 25, 2013

done: 1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment