make util/has_lib.sh work properly on Debian #216

Merged
merged 1 commit into from Dec 6, 2013

Conversation

Projects
None yet
10 participants
Contributor

aadamowski commented Sep 23, 2012

The current version of util/has_lib.sh fails to detect libraries on Debian, for 2 reasons:

  1. On Debian, ldconfig lies in /sbin/ and therefore isn't found if run by a non-root user
  2. On Debian, libjpeg is in /usr/lib/x86_64-linux-gnu/libjpeg.so , which is not included in the set of library paths for searching.

My commit remedies both of those problems.

zilluss commented Sep 27, 2012

I second the ldconfig-problem for Suse

rla commented May 11, 2013

ldconfig problem also happens on Slackware

Thank you, Aleksander.

fermion commented Oct 31, 2013

👍

bimusiek commented Dec 4, 2013

Why is it still not merged to main repository? I was searching for bug for few hours and this is issue, that has_lib is returning false even if there is libjpeg!

Thanks @aadamowski :)

pansen commented Dec 4, 2013

and if you're already changing this, can you please add the following as well :)
::

for dir in /lib /usr/lib /usr/local/lib /opt/local/lib /usr/lib/x86_64-linux-gnu /usr/lib/i386-linux-gnu $(echo $LIBRARY_PATH|tr ':' ' '); do
Collaborator

kangax commented Dec 4, 2013

@TooTallNate @rvagg ok to pull this in?

Contributor

TooTallNate commented Dec 4, 2013

Seems OK to me

Collaborator

rvagg commented Dec 5, 2013

+1, good enough to get the job done for now

kangax added a commit that referenced this pull request Dec 6, 2013

Merge pull request #216 from aadamowski/master
make util/has_lib.sh work properly on Debian

@kangax kangax merged commit b4d803b into Automattic:master Dec 6, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment