Add another search path for system dependencies [Ubuntu 12.04] #247

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

fermion commented Jan 17, 2013

This was my solution for the problem in #244. I'd installed dependencies using apt-get according to the installation instructions but I wasn't getting jpeg/gif support. has_lib.sh wasn't finding anything.

This may or may not be a proper solution for this. Perhaps the test should recurse rather than add a specific sub directory? I feel like I'm out of my league here but I'd love to save someone else this hassle.

fermion commented Jan 17, 2013

Looks like this has been an issue for others:

aadamowski/node-canvas@b9003c6

I still think the test should probably recurse rather than continue appending different known system libraries.

Contributor

TooTallNate commented Jan 17, 2013

What do you mean by "recurse"?

Contributor

TooTallNate commented Jan 17, 2013

Ideally we add LIBRARY_PATH env variable support here.

fermion commented Jan 17, 2013

The common library check already looks in /usr/lib, my libs were in /usr/lib/x86_64-linux-gnu. If it walked sub-directories of the common lib paths it would've found mine.

fermion commented Jan 17, 2013

I've had some sleep now, yes, adding a LIBRARY_PATH that gives has_lib.sh a hint would be better than this!

Collaborator

kangax commented Oct 31, 2013

Is this still a problem?

fermion commented Oct 31, 2013

Yes, but the work around is simple.

Collaborator

kangax commented Oct 31, 2013

@TooTallNate @rvagg looks like it makes sense to pull this in

Collaborator

rvagg commented Oct 31, 2013

Only for 64bit Ubuntu, it's kind of specific; also this dir should be included in /etc/ld.so.conf.d/ somewhere, otherwise the system would be broken methinks.

Since has_lib.sh does an ldconfig -p, the simple fix is to actually fix up your ld.so.conf, even if that means just putting in '/usr/lib/x86_64-linux-gnu'to that file and runningsudo ldconfig` again.

-1 for me but it's really no big deal either way.

fermion commented Oct 31, 2013

@rvagg I'm fine with requiring 64bit users to do some extra configuration to pull in the relevant libraries. Perhaps this is better solved through documentation?

Collaborator

rvagg commented Oct 31, 2013

I guess the best solution would probably be to mirror what gcc and/or gyp are doing to find the libraries themselves, perhaps that is LIBRARY_PATH if those paths aren't in ld.so.conf?

Collaborator

kangax commented Oct 31, 2013

Looks like #216 addresses similar issue and adds even more to the path

kangax closed this Dec 6, 2013

Collaborator

kangax commented Dec 6, 2013

Closing, now that #216 is in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment