Clamp JPEG buffer size. Fixes #674 #739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Also, if someone could confirm that the clamping criteria are correct, that would be great. I'm not positive that the buffer should never exceed the size of the canvas.w * canvas.h * 4. (Linus' test case passes though.) Edit: I think it's true that the JPEG buffer will never exceed the size of the pixel array, and perhaps that's all we care about, but usually the buffer will be much smaller. |
Collaborator
|
Sorry for forgetting about this, merging now |
Collaborator
|
Released as 1.3.14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: I was somewhat surprised that the default of 4096 doesn't likewise cause errors for tiny canvases...