New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable @mentions in posts and comments #3

Open
allendav opened this Issue Jun 9, 2015 · 8 comments

Comments

Projects
None yet
9 participants
@allendav
Contributor

allendav commented Jun 9, 2015

Allow admin, editor and author users to @mention other blog users in posts and comments. The implementation should also include email and/or admin-bar notifications.

The majority of the front-side code is already there. This is already supported as well for o2 on WordPress.com. It is the self-hosted server side work that needs fleshing out.

@allendav allendav added the bug label Jun 9, 2015

@iamchrissmith

This comment has been minimized.

Show comment
Hide comment
@iamchrissmith

iamchrissmith Jun 24, 2015

@allendav so does the @mention functionality not currently work on self-hosted blogs?

@allendav so does the @mention functionality not currently work on self-hosted blogs?

@westonruter

This comment has been minimized.

Show comment
Hide comment
@westonruter

westonruter Jul 17, 2015

Contributor

No, it's not working on self-hosted blogs.

Contributor

westonruter commented Jul 17, 2015

No, it's not working on self-hosted blogs.

@mikezielonka

This comment has been minimized.

Show comment
Hide comment
@mikezielonka

mikezielonka Nov 5, 2015

+1 to fixing :)

+1 to fixing :)

@jrtashjian

This comment has been minimized.

Show comment
Hide comment
@jrtashjian

jrtashjian Dec 3, 2015

+1 to fixing as well. @allendav could you point me in the direction of where I should start looking to fix this? I can't seem to figure out where this code exists but I'd like to take a stab at it.

As for getting mentions to work for myself, the notifications feature of BuddyPress has enabled email notifications and @mention linking. However it doesn't have the autocomplete functionality.

+1 to fixing as well. @allendav could you point me in the direction of where I should start looking to fix this? I can't seem to figure out where this code exists but I'd like to take a stab at it.

As for getting mentions to work for myself, the notifications feature of BuddyPress has enabled email notifications and @mention linking. However it doesn't have the autocomplete functionality.

@lancewillett lancewillett added enhancement and removed bug labels Dec 9, 2015

@jrtashjian

This comment has been minimized.

Show comment
Hide comment
@jrtashjian

jrtashjian Jan 7, 2016

What I've found so far is O2 is attempting to enqueue a javascript file which doesn't exist anywhere. I found this in the o2_Suggestions class here:

wp_enqueue_script( 'o2-suggestions', plugins_url( 'js/suggestions.js', __FILE__ ), array( 'jquery' ) );

I believe suggestions.js should exist here but it does not: https://github.com/Automattic/o2/tree/cc022db37da7d1274cfc499a7f2ba0cff5a8c9ea/js

Can this file just be dropped in or must it be modified for use outside of WordPress.com?

What I've found so far is O2 is attempting to enqueue a javascript file which doesn't exist anywhere. I found this in the o2_Suggestions class here:

wp_enqueue_script( 'o2-suggestions', plugins_url( 'js/suggestions.js', __FILE__ ), array( 'jquery' ) );

I believe suggestions.js should exist here but it does not: https://github.com/Automattic/o2/tree/cc022db37da7d1274cfc499a7f2ba0cff5a8c9ea/js

Can this file just be dropped in or must it be modified for use outside of WordPress.com?

@mrjarbenne

This comment has been minimized.

Show comment
Hide comment
@mrjarbenne

mrjarbenne Dec 19, 2016

This is a hard one to explore creating a patch for, particularly if there is working code that needs to be ported over. I can hide the filter, but having @mentions appear as one of the options in the O2 filter widget teases how nice this would be to have on a self hosted install:

2016-12-19_09-07-02

It looks like this is tied to Jetpack, but doesn't seem to want to trigger (I can't find mention of this at all in the Jetpack repo): https://github.com/Automattic/o2/blob/master/modules/suggestions/js/suggestions.js

This is a hard one to explore creating a patch for, particularly if there is working code that needs to be ported over. I can hide the filter, but having @mentions appear as one of the options in the O2 filter widget teases how nice this would be to have on a self hosted install:

2016-12-19_09-07-02

It looks like this is tied to Jetpack, but doesn't seem to want to trigger (I can't find mention of this at all in the Jetpack repo): https://github.com/Automattic/o2/blob/master/modules/suggestions/js/suggestions.js

@allysonsouza

This comment has been minimized.

Show comment
Hide comment

+1

@madebytincans

This comment has been minimized.

Show comment
Hide comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment