Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing alt attribute to avatars #148

Merged

Conversation

@audrasjb
Copy link
Contributor

commented Jan 12, 2018

Hi,
cc @ocean90,

Even empty, alt attribute should always be set to avoid assistive technologies to vocalize the file name. I guess we do not need to put author's name since it's always displayed close to the avatar. We do not need to use alt texts like "avatar" because this provide no information for the user of AT.

See Andrea's issue opened in meta.trac.w.org here: https://meta.trac.wordpress.org/ticket/3371

This patch was tested on a local instance of o2. Seems to fix the issue.

Cheers,
Jb

@audrasjb

This comment has been minimized.

Copy link
Contributor Author

commented Jan 13, 2018

Hi,

For your information, this accessibility issue is explained on this document: https://www.w3.org/WAI/tutorials/images/decision-tree/
We are in the case of decorative images. Images are wrapped in a link, but this link is always duplicated with the author name juste after the image. So we dont need any alt text, just a simple empty alt attribute.

That would be wonderful if someone could review my patch and merge because this is a sensible issue for all o2 websites on make.wordpress.org!
AT users can be very disturbed by the vocalisation of images on pages like https://make.wordpress.org/core/

ps: my patch have some issue with Travis checks. No ideao where it comes from ¯_(ツ)_/¯

Many thanks!
Jb

@obenland obenland requested a review from pento Jan 20, 2018

@pento
pento approved these changes Jan 22, 2018
Copy link
Member

left a comment

👍🏻

@pento pento merged commit b45aac6 into Automattic:master Jan 22, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.