Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podcasts page scrolls slightly horizontal #1930

Closed
1 task done
azollafox opened this issue Jul 23, 2024 · 10 comments · Fixed by #1943
Closed
1 task done

Podcasts page scrolls slightly horizontal #1930

azollafox opened this issue Jul 23, 2024 · 10 comments · Fixed by #1943
Labels
[Type] Bug Used for issues where something is not functioning as intended.

Comments

@azollafox
Copy link

Description

When scrolling down in the list of podcasts on the podcast page it is possible to scroll horizontally a bit as well

Step-by-step reproduction instructions

  1. Open Podcast Page
  2. Scroll down and move finger right to left as well

I am able to inconsistently reproduce on my iPhone SE, Pocket Casts 7.67

Screenshots or screen recording

https://d.pr/v/gcawUs

Did you search for existing bug reports?

  • I have searched for existing bug reports.

Device, Operating system, and Pocket Casts app version

Pocket Casts v7.68
Device: iPhone13,3
OS: 17.5.1

@leandroalonso
Copy link
Member

leandroalonso commented Jul 23, 2024

cc @SergioEstevao (I believe this was reported before but I couldn't find the issue/thread — and if my memory is not failing it was in a small screen device).

Edit: found it.

@rviljoen
Copy link
Contributor

I sporadically see this on iPhone 14 Pro as well:

image

@joashrajin
Copy link

+1 at 8516326-zd-a8c

2024-07-03.22.41.00.mov

@rviljoen
Copy link
Contributor

@SergioEstevao I wonder if this bug may be related to this change: b7a14a6

When the UI is displayed correctly, then the x inset value is -16:
image

When the UI is incorrect, the x inset value is 0:
image

@SergioEstevao
Copy link
Contributor

Thanks @rviljoen ! I'm having a look into this today. Should have a Pr out with a fix later today.

@rviljoen
Copy link
Contributor

Hi @SergioEstevao - I tested the code change in #1943 and can still reproduce the issue. I can now replicate it consistently by scrolling up/down/left/right quickly, and periodically releasing touch. The left margin disappears upon releasing touch after the rapid scrolls and returns as soon as you touch the screen again (PS - I also saw this behaviour under normal scrolling, but with rapid scrolling I was able to consistently reproduce it, which may be useful for you to find the bug).

ScreenRecording_07-25-2024.16-24-19_1.mov

@SergioEstevao
Copy link
Contributor

Thanks for testing it @rviljoen ! I will give it another look.

@bikrrr
Copy link
Contributor

bikrrr commented Aug 4, 2024

I'm glad this is being looked at—it's been bugging me since the podcast grid update. The issue is most noticeable when there are more rows than can fit on the screen and happens in both 4-column and 3-column grid sizes.

If I start with the grid at the bottom (so the Search box is visible), I just scroll up slightly and the grid will shift left. Here's my repro on an iPhone 15 Pro, iOS 17.6, and Pocket Casts 7.68:

Pocket.Casts.Grid.Shift.mp4

@rviljoen
Copy link
Contributor

rviljoen commented Aug 4, 2024

@bikrrr This was fixed in the latest beta and should make it into the 7.69 public release 👌🏻

@rviljoen
Copy link
Contributor

rviljoen commented Aug 6, 2024

@azollafox This was fixed via #1943 and released in v7.69.

@pachlava pachlava added the [Type] Bug Used for issues where something is not functioning as intended. label Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Used for issues where something is not functioning as intended.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants