Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix video/mp4 content type back for file handling #1918

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Fix video/mp4 content type back for file handling #1918

merged 1 commit into from
Jul 18, 2024

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Jul 17, 2024

Fixes an issue where video mp4s would not play

To test

  • Add a mp4 file to the Files app
  • Go back to Pocket Casts
  • Navigate to Profile > Files > Add File
  • Pick the mp4 and add it
  • Make sure the mp4 plays back

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus
Add video/mp4 content type back to file handling
283a77b 
Fixes an issue where video mp4s would not play
@bjtitus bjtitus added the [Type] Bug Used for issues where something is not functioning as intended. label Jul 17, 2024
@bjtitus bjtitus added this to the 7.68 ❄️ milestone Jul 17, 2024
@bjtitus bjtitus requested a review from a team as a code owner July 17, 2024 20:48
@bjtitus bjtitus requested review from leandroalonso and removed request for a team July 17, 2024 20:48
@leandroalonso leandroalonso merged commit 14748e3 into release/7.68 Jul 18, 2024
5 of 8 checks passed
@leandroalonso leandroalonso deleted the bjtitus/bugs/mp4-playback branch July 18, 2024 09:08
@bjtitus bjtitus mentioned this pull request Jul 22, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandroalonso leandroalonso leandroalonso approved these changes

Assignees
No one assigned
Labels
[Type] Bug Used for issues where something is not functioning as intended. [Type] Fix
Projects
None yet
Milestone
7.68
Development

Successfully merging this pull request may close these issues.
3 participants
@bjtitus @leandroalonso @pachlava