New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter issues #2260

Merged
merged 6 commits into from Nov 7, 2018

Conversation

Projects
None yet
3 participants
@alexsanford
Contributor

alexsanford commented Sep 28, 2018

Some more linter issues to fix for WPCOM deployment.

  • Cannot have underscores in filenames. Please test the question_type-*.php templates. Third party code may still be using the underscore in the name, so the code should load that first, if it exists, and then look for a file with the new name (question-type-*.php).

  • Cannot have relative require or include statements, so we should use dirname( __FILE__ ) to make them absolute. Please ensure that the files are still being loaded properly.

  • One translator issue. See this string by visiting Learner Management > [Course] > Lessons > Manage Learners.

  • One issue with trailing spaces after the closing PHP tag (fixed by removing the closing PHP tag).

@alexsanford alexsanford added this to the 1.12.0 milestone Sep 28, 2018

@alexsanford alexsanford self-assigned this Sep 28, 2018

@alexsanford alexsanford requested review from pgk and donnapep Sep 28, 2018

@donnapep

This comment has been minimized.

Contributor

donnapep commented Sep 28, 2018

@alexsanford Is this something that can go in a subsequent release? I'm not sure we should add this into the current release given that we already have a beta out. The file renaming bit feels the most risky.

@alexsanford alexsanford modified the milestones: 1.12.0, 1.12.1 Sep 28, 2018

@alexsanford

This comment has been minimized.

Contributor

alexsanford commented Sep 28, 2018

@donnapep Yeah good point. Moving to 1.12.1 for now.

@pgk

pgk approved these changes Sep 28, 2018

Looks good, all changes make sense. If the ways users could be affected by the filename change are thought out, its 💯

alexsanford added some commits Sep 27, 2018

Rename files with underscores in the filename
Note that because these files are templates that could be overridden, we
have to search first for the old name (with the underscore) and then the
new name when trying to locate the template. This ensures that it will
continue to work properly for current sites with the filename overrides.

@alexsanford alexsanford force-pushed the fix/linter-issues branch from e74e7af to c13d127 Oct 19, 2018

@alexsanford

This comment has been minimized.

Contributor

alexsanford commented Oct 19, 2018

Note: rebased to include fixes in 1.12.0-beta.2

@donnapep

👍

@alexsanford alexsanford merged commit f5cc585 into master Nov 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alexsanford alexsanford deleted the fix/linter-issues branch Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment