Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix theme compatibility issues for Message comments #2266
This PR fixes two issues that were found on the Message page on unsupported themes:
I don't think pagination is quite working for messages.
Using Astra, I see Previous Page on the
Also, I have two messages. When I select the first one, I see Previous Message pagination instead of Next Message.
Do you happen to know if pagination existed for messages before? If not, perhaps we shouldn't worry about it here.
@donnapep I dug into this quite a bit.
The pagination/navigation links you saw are coming from the theme. Frankly, I think that Astra has some other problems with these links, because they were acting really weird for me on regular Posts as well.
In any case, I think the solution is to try to turn off the theme's pagination for Sensei pages. I've added that in the latest two commits. Each of the individual handlers adds Sensei's pagination links as needed anyway, so having the theme do it as well is redundant.
Note that this will only work if the theme is using canonical pagination (i.e. using something like
Anyway, please re-test this and see if it works for you.
Yes, exactly. It would just mean that my code to turn off theme-based pagination doesn't work, and the theme will show its pagination. Which may or may not be as messed up as Astra