New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP warnings when ordering courses, modules or lessons #2300

Merged
merged 2 commits into from Nov 7, 2018

Conversation

Projects
None yet
2 participants
@donnapep
Contributor

donnapep commented Nov 7, 2018

This PR addresses the following warning that is generated in PHP 7.2 when ordering courses, modules or lessons - PHP Warning: count(): Parameter must be an array or an object that implements Countable.

lkraav and others added some commits Oct 21, 2018

@donnapep donnapep added this to the 1.12.2 milestone Nov 7, 2018

@donnapep donnapep self-assigned this Nov 7, 2018

@donnapep donnapep merged commit dd4f7ff into master Nov 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@donnapep donnapep deleted the pr/2281 branch Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment