New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP warning on Course Results page #2301

Merged
merged 1 commit into from Nov 9, 2018

Conversation

Projects
None yet
2 participants
@donnapep
Contributor

donnapep commented Nov 7, 2018

Fixes #2254.

Testing

  1. Start a course with at least one optional quiz.
  2. Complete a lesson without completing the quiz.
  3. View the Course Results page (/course//results).
  4. Ensure the following PHP warning is not logged:
    A non-numeric value encountered in /var/www/html/wp-content/plugins/sensei/includes/class-sensei-utils.php.

Note that #2254 (comment) will be fixed in a separate PR.

@donnapep donnapep added this to the 1.12.2 milestone Nov 7, 2018

@donnapep donnapep self-assigned this Nov 7, 2018

@donnapep donnapep requested a review from alexsanford Nov 7, 2018

@donnapep donnapep changed the title from Cast value before using in calculation to Fix PHP warning on Course Results page Nov 7, 2018

@donnapep donnapep merged commit 438dfa5 into master Nov 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@donnapep donnapep deleted the fix/course-results-php-warning branch Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment