New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP warnings on Sensei Analysis page #2305

Merged
merged 1 commit into from Nov 15, 2018

Conversation

Projects
None yet
2 participants
@donnapep
Contributor

donnapep commented Nov 9, 2018

This PR fixes the count warnings that appear on the Sensei > Analysis page when:

  • On the Learners subpage, a learner had only ever taken 1 quiz:
    screen shot 2018-11-09 at 5 56 53 am
  • On the Courses subpage, only 1 learner had taken a quiz for a particular course:
    screen shot 2018-11-09 at 6 00 08 am
  • On the Lessons subpage, a particular lesson's quiz had only ever been taken once:
    screen shot 2018-11-09 at 6 05 32 am

Testing

  • Create some data as per the above.
  • On the Sensei > Analysis page, click on each of Learners, Courses and Lessons.
  • Ensure that no PHP count warning appears in the logs.
  • Check that the Average Grade or Average Percentage column values remain unchanged.

@donnapep donnapep self-assigned this Nov 9, 2018

@donnapep donnapep added this to the 1.12.2 milestone Nov 9, 2018

@donnapep donnapep requested a review from alexsanford Nov 9, 2018

@alexsanford

LGTM

@donnapep donnapep merged commit 37e685d into master Nov 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@donnapep donnapep deleted the fix/count-warning branch Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment