New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing translations on Messages screen #2310

Merged
merged 2 commits into from Nov 15, 2018

Conversation

Projects
None yet
2 participants
@donnapep
Contributor

donnapep commented Nov 9, 2018

Fixes #2308.

Testing

I don't see a way to test this since translations come from Transifex and this is a new string that needs to be translated. The best we can probably do is to check that the text still appears for English.

@donnapep donnapep self-assigned this Nov 9, 2018

@donnapep donnapep added this to the 1.12.2 milestone Nov 9, 2018

@donnapep donnapep changed the title from Fix/messages i18n to Fix translations on Messages screen Nov 9, 2018

@donnapep donnapep requested a review from alexsanford Nov 9, 2018

@donnapep donnapep changed the title from Fix translations on Messages screen to translations on Messages screen Nov 9, 2018

@donnapep donnapep changed the title from translations on Messages screen to Add missing translations on Messages screen Nov 9, 2018

@donnapep donnapep merged commit 83d6c05 into master Nov 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@donnapep donnapep deleted the fix/messages-i18n branch Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment