Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version numbers and add `ABSPATH` checks in templates #2488

Merged
merged 1 commit into from Mar 19, 2019

Conversation

Projects
None yet
2 participants
@jom
Copy link
Member

commented Mar 15, 2019

This PR updates the version numbers on templates and does some minor clean up.

Any file that has translated strings gets bumped to 2.0.0. Other files needed a version bump as well. I only bumped the version if the changes since marked version were substantial. Most were from our PHPCS cleanup when we added escaping. I didn't, for example, bump the versions for changes just made to whitespace/code formatting or adding/modifying the ABSPATH check.

In terms of cleanup:

  • Moved ABSPATH checks below docblock for PHPCS.
  • Added a few ABSPATH checks.
  • Merged neighboring php blocks in the header (sometimes footer).
  • Did some minor fixes with indenting (might be easier to review without whitespace changes), but nothing too extreme.

@jom jom added this to the 2.0.0 milestone Mar 15, 2019

@jom jom requested review from alexsanford and donnapep Mar 15, 2019

@jom jom merged commit 55ccba2 into release/2.0 Mar 19, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@jom jom deleted the update/template-versions branch Mar 19, 2019

@donnapep donnapep changed the title Update template version numbers Update version numbers and add `ABSPATH` checks in templates Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.