Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for late additions to data updates #2490

Merged
merged 1 commit into from Mar 19, 2019

Conversation

Projects
None yet
3 participants
@jom
Copy link
Member

commented Mar 18, 2019

This changes data updates to allow for late changes using the sensei_upgrade_functions filter. Before plugins would only be able to use this filter if they were loaded before Sensei. While running apply_filters( 'sensei_upgrade_functions', ... ) every time we fetch the updates isn't very performant, it was the only way I could think of to not break people possibly manually adding to the public \Sensei_Updates::$updates property.

Testing

  • Run data updates and make sure they run both from plugins using sensei_upgrade_functions and Sensei core.

@jom jom added this to the 2.0.0 milestone Mar 18, 2019

@jom jom requested review from alexsanford and donnapep Mar 18, 2019

@donnapep
Copy link
Contributor

left a comment

Works now. 👍

@jom jom merged commit ab10463 into release/2.0 Mar 19, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@jom jom deleted the change/data-updates-loading branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.