Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename plugin to Sensei LMS #2511

Merged
merged 5 commits into from Apr 12, 2019

Conversation

Projects
None yet
3 participants
@jom
Copy link
Member

commented Apr 5, 2019

To avoid conflicts with the 1.x branch, this PR renames the plugin from Sensei to Sensei LMS.

This PR

  • Renames plugin from Sensei to Sensei LMS.
  • Renames text domain from sensei to sensei-lms.
  • Renames main plugin file from sensei.php to sensei-lms.php

This PR does not

  • Update mentions of Sensei in plugin messages and notifications.
  • Update the template override prefix (still yourtheme/sensei/template-name.php)
  • Update setting prefixes.
  • Update PHP class prefixes.
  • Update global function prefixes.
  • Update hook prefixes.
  • Update CSS selector (class/ID) prefixes.
  • Update tokens used throughout plugin.
  • Update other references to Sensei or sensei.

@jom jom added this to the 2.0.0 milestone Apr 5, 2019

@jom jom requested review from alexsanford and donnapep Apr 5, 2019

@donnapep
Copy link
Collaborator

left a comment

👍

@alexsanford
Copy link
Contributor

left a comment

LGTM

"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Report-Msgid-Bugs-To: https://www.transifex.com/woothemes/sensei-by-woothemes/\n"
"Report-Msgid-Bugs-To: https://translate.wordpress.org/projects/wp-plugins/sensei/\n"

This comment has been minimized.

Copy link
@alexsanford

alexsanford Apr 12, 2019

Contributor

This should be sensei-lms as well. We'll be regenerating this file when we release though, so not a big deal.

This comment has been minimized.

Copy link
@jom

jom Apr 12, 2019

Author Member

Ahhh yeah, I updated gulpfile but didn't regenerate.

@jom jom merged commit c65b41b into master Apr 12, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@jom jom deleted the rename/plugin-sensei-lms branch Apr 12, 2019

@donnapep donnapep modified the milestones: 2.0.0, 2.0.1 Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.