New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging for settings update #2684
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few super minor issues, otherwise looks good and works well.
When changing the checkbox settings under Email Notifications, I only get 3 distinct settings being logged - |
@donnapep Good catch on that one. This proved to be a bit tricky. In every other case when a setting changes, we want only to log the setting field name. However, for the checkboxes, the setting is stored as an array of strings, where each string is the name of the individual checkbox that was checked. I added some code to handle this case (along with tests). It seems to work well, but please do re-test. Also @jom I've re-requested your review because I would like you to take a look at the new code if you have a chance (944c500). It is functional, but I'm a bit worried about the readability. Would appreciate your input 🙂 |
@alexsanford Thanks! This is what I'm seeing logged now: Is it possible to drop the |
@donnapep This should be fixed now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now!
Closes #2645
See the issue for the event description. Note that the
view
property names have been changed to match the section slugs, and the values insettings
are comma-separated.This PR also adds a helper class for testing logged events.
Testing Instructions
view
andsettings
properties have the correct values based on the settings that were changed.