Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize loading of teacher dropdown on Courses page #2750

Conversation

@mostafaabd
Copy link
Contributor

mostafaabd commented Jul 4, 2019

What I do to Reproduce the issue (#2215):

1- Add 44717 customers.
2- Add 2,969 teachers.
3- I used the Query Monitor plugin

What Happened
Sensei plugin calls function WP_User_Query->query() several times, when we can use it once.
I hope this PR fix this issue @sophosscott @LukeAbel

themaster

themaster-after

@mostafaabd

This comment has been minimized.

Copy link
Contributor Author

mostafaabd commented Sep 5, 2019

@donnapep, Could you review this PR, please?
If this PR doesn't fix the issue it can enhance code performance.

@donnapep donnapep added this to the 2.2.1 milestone Oct 15, 2019
Copy link
Collaborator

donnapep left a comment

Looks good! Note that this doesn't really fix #2215, as it only improves performance when there are a lot of teachers that need to be added to the teacher filter dropdown.

@donnapep donnapep merged commit 2127409 into Automattic:master Oct 15, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mostafaabd mostafaabd deleted the mostafaabd:enhance-performance-admin-list-courses-page branch Oct 15, 2019
@donnapep donnapep changed the title enhance performance to admin list courses page issue (#2215) Optimize loading of teacher dropdown on Courses page Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.