Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not limit message comments on single post comment feeds #2776

Merged
merged 1 commit into from Oct 15, 2019

Conversation

@jom
Copy link
Member

jom commented Sep 6, 2019

Fixes #2759

Fixes issue with MySQL error when posts table isn't being joined. When WordPress queries comments for a single post in the feed, it doesn't join with the posts table. Messages themselves shouldn't have comment feeds.

Testing Instructions

  • See issue #2759 for testing instructions. I might have had to add a lesson to the course, but might have just been me.
  • Verify private message responses are still hidden in /comments/feed (#2726)
  • Note: I disabled browser caching while testing this. I also disabled feed caching using this snippet, but not sure if necessary:
add_action( 'wp_feed_options', function ( $feed ) {
	$feed->enable_cache( false );
} );
Fixes issue with MySQL error when posts table isn't being queried
@jom jom requested review from roundhill, alexsanford and donnapep Sep 6, 2019
@jom jom self-assigned this Sep 6, 2019
@jom jom added the [Type] Bug label Sep 6, 2019
Copy link
Contributor

alexsanford left a comment

This seems to work fine for me 👍

@donnapep donnapep added this to the 2.2.1 milestone Sep 30, 2019
Copy link
Collaborator

donnapep left a comment

👍

@jom jom merged commit 211e489 into master Oct 15, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jom jom deleted the fix/comment-feed branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.