Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow HTML in question titles #2780

Merged
merged 1 commit into from Oct 15, 2019

Conversation

@jom
Copy link
Member

jom commented Sep 26, 2019

Fixes #2779

While investigating this issue it seemed easier to fix it. We started stripping HTML from question titles last year, including HTML that comes from the_content filters (such as this LaTeX image).

One note: Most of the quiz bits are being double wp_kses'd right now. We have sanitizers in both methods that get fields and the methods that output fields. I just kept that for now and switched to wp_kses_post.

See issue for testing instruction.

@jom jom requested review from roundhill, alexsanford and donnapep Sep 26, 2019
@jom jom self-assigned this Sep 26, 2019
@donnapep donnapep added this to the 2.2.1 milestone Sep 30, 2019
Copy link
Collaborator

donnapep left a comment

👍

Copy link
Contributor

alexsanford left a comment

🚢

@jom jom merged commit 6c4f6c9 into master Oct 15, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jom jom deleted the fix/latex-html-escape branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.