Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default wrapper around single post renderer on unsupported theme #2786

Merged
merged 1 commit into from Oct 15, 2019

Conversation

@jom
Copy link
Member

jom commented Oct 15, 2019

This fixes an issue related to unsupported themes outputting wrapper-start.php on pages that use the single post renderer. This removes the sensei_output_content_wrapper method on the sensei_before_main_content action to prevent conflict with unsupported themes.

In addition, I moved this block of code below ob_start() to prevent any future hook output from displaying during the tests.

Testing Instructions

  • Activate an unsupported theme.
  • View the course and lesson pages and make sure tags are correctly nested and the contents of wrapper-start.php are not output.
  • Run tests and make sure no HTML output is displayed.
  • Make sure issue fixed in #2756 is still fixed.
@jom jom requested review from roundhill, alexsanford, donnapep and gkaragia Oct 15, 2019
@jom jom self-assigned this Oct 15, 2019
@jom jom added the [Type] Bug label Oct 15, 2019
Copy link
Collaborator

donnapep left a comment

Nice. 👍

@donnapep donnapep added this to the 2.2.1 milestone Oct 15, 2019
Copy link
Contributor

alexsanford left a comment

LGTM!

@jom jom merged commit ab167eb into master Oct 15, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jom jom deleted the fix/content-wrapper-unsupported-themes branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.