New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove setup notices #3155
Merged
Merged
Remove setup notices #3155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donnapep
reviewed
May 14, 2020
donnapep
reviewed
May 15, 2020
donnapep
previously approved these changes
May 15, 2020
renatho
reviewed
May 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! A lot of code removed! \o/
Besides the few comments, only a reminder to add the deprecated methods to the removal issue ;)
yscik
commented
May 18, 2020
renatho
approved these changes
May 18, 2020
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3046
Changes proposed in this Pull Request
Testing instructions
Deprecated Code
Sensei_Admin::install_pages_output
Sensei_Admin::admin_install_notice
Sensei_Admin::admin_installed_notice
Sensei_Admin::admin_notices_styles
Sensei_Admin::install_pages
Sensei_Usage_Tracking_Base::hide_tracking_opt_in
Sensei_Usage_Tracking_Base::is_opt_in_hidden
Sensei_Usage_Tracking_Base::opt_in_dialog_text_allowed_html
Sensei_Usage_Tracking_Base::maybe_display_tracking_opt_in
Sensei_Usage_Tracking_Base::handle_tracking_opt_in
Sensei_Usage_Tracking_Base::enqueue_script_deps
Sensei_Usage_Tracking_Base::output_opt_in_js