Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setup notices #3155

Merged
merged 9 commits into from May 18, 2020
Merged

Remove setup notices #3155

merged 9 commits into from May 18, 2020

Conversation

yscik
Copy link
Contributor

@yscik yscik commented May 14, 2020

Fixes #3046

Changes proposed in this Pull Request

  • Remove Install Sensei LMS Pages notice and related handlers, success notices.
  • Remove Enable Usage Tracking notice, dialog, handlers and tests.
  • Deprecate public methods related to those

Testing instructions

  • Reset a site
  • Activate Sensei LMS plugin
  • No notices other than the Setup Wizard one should be visible.

Deprecated Code

  • Sensei_Admin::install_pages_output

  • Sensei_Admin::admin_install_notice

  • Sensei_Admin::admin_installed_notice

  • Sensei_Admin::admin_notices_styles

  • Sensei_Admin::install_pages

  • Sensei_Usage_Tracking_Base::hide_tracking_opt_in

  • Sensei_Usage_Tracking_Base::is_opt_in_hidden

  • Sensei_Usage_Tracking_Base::opt_in_dialog_text_allowed_html

  • Sensei_Usage_Tracking_Base::maybe_display_tracking_opt_in

  • Sensei_Usage_Tracking_Base::handle_tracking_opt_in

  • Sensei_Usage_Tracking_Base::enqueue_script_deps

  • Sensei_Usage_Tracking_Base::output_opt_in_js

@yscik yscik requested a review from a team May 14, 2020 12:04
includes/class-sensei-admin.php Outdated Show resolved Hide resolved
includes/class-sensei-admin.php Outdated Show resolved Hide resolved
@donnapep donnapep added this to the 3.1.0 milestone May 15, 2020
@donnapep donnapep added the Deprecation This change introduces a deprecation. label May 15, 2020
donnapep
donnapep previously approved these changes May 15, 2020
Copy link
Contributor

@renatho renatho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! A lot of code removed! \o/

Besides the few comments, only a reminder to add the deprecated methods to the removal issue ;)

includes/class-sensei-admin.php Outdated Show resolved Hide resolved
includes/class-sensei-data-cleaner.php Show resolved Hide resolved
@yscik yscik merged commit b02a323 into master May 18, 2020
@yscik yscik deleted the remove/setup-notices branch May 18, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecation This change introduces a deprecation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove notices that are part of the onboarding wizard
3 participants