Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Take Course block to Course Sign Up #4288

Merged
merged 3 commits into from Aug 23, 2021

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Aug 20, 2021

Fixes #4285

Changes proposed in this Pull Request

  • Rename Take Course block to Course Sign Up.

I was planning to also change the block name 'sensei-lms/button-take-course', but it seems it's not possible without breaking backward compatibility.

Testing instructions

  • Go to the master branch.
  • Create a course with the Take Course button.
  • Go to this branch.
  • Select the block, and make sure the name is "Course Sign Up" now.
  • Also make sure it continues working properly for courses with associated products.

@renatho renatho added this to the 3.13.1 milestone Aug 20, 2021
@renatho renatho requested a review from a team August 20, 2021 17:44
@renatho renatho self-assigned this Aug 20, 2021
@donnapep
Copy link
Collaborator

I was reading about the difference between "Sign Up" and "Signup". "Sign Up" is a verb while "Signup" is a noun. I think here we want to use the noun version (i.e. Signup), since we're referring to a thing (i.e. course signup).

If we were wanting to use it as a verb, then it would be something like "Sign Up for Course", since nouns typically follow verbs.

All that to say that I think "Course Sign Up" should be "Course Signup". Yes, I went way deep on this. 😄

@renatho
Copy link
Contributor Author

renatho commented Aug 23, 2021

I was reading about the difference between "Sign Up" and "Signup". "Sign Up" is a verb while "Signup" is a noun. I think here we want to use the noun version (i.e. Signup), since we're referring to a thing (i.e. course signup).

If we were wanting to use it as a verb, then it would be something like "Sign Up for Course", since nouns typically follow verbs.

All that to say that I think "Course Sign Up" should be "Course Signup". Yes, I went way deep on this. 😄

Makes sense! Updated here: 3cbc23c

@renatho renatho merged commit 88c1dac into master Aug 23, 2021
@renatho renatho deleted the update/take-course-block-name branch August 23, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Take Course block to Course Sign Up
2 participants