Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check pause method exists for given object #4628

Merged
merged 1 commit into from Jan 14, 2022
Merged

Conversation

merkushin
Copy link
Member

Changes proposed in this Pull Request

  • Check the pause method exists before invoking it

Testing instructions

  • Enable the feature flag: add_filter( 'sensei_feature_flag_video_based_course_progression', '__return_true' );
    The preferable place is inside sensei-lms.php, somewhere in the beginning.
  • Run npm start
  • Enable autopause video setting for a course.
  • Add a YouTube/Vimeo/Video block to the course lesson.
  • Open the lesson with the video.
  • Test auto-pause:
    • Start playing video.
    • Try to change tab/window.
    • Video should be paused.

Copy link
Member

@m1r0 m1r0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@merkushin merkushin merged commit 015c486 into master Jan 14, 2022
@merkushin merkushin deleted the fix/pause-method-exists branch January 14, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants