Add Confirm Dialog component #5361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mimicking the Gutenberg's experimental Confirm Dialog component, so it's easier to replace later.
Exporting the new component and the new related hook.
Codecov Report
@@ Coverage Diff @@
## trunk #5361 +/- ##
=========================================
Coverage 40.81% 40.81%
- Complexity 8638 8639 +1
=========================================
Files 285 285
Lines 29119 29131 +12
=========================================
+ Hits 11885 11891 +6
- Misses 17234 17240 +6
Continue to review full report at Codecov.
|
renatho
reviewed
Jul 19, 2022
assets/blocks/editor-components/confirm-dialog/confirm-dialog.js
Outdated
Show resolved
Hide resolved
assets/blocks/editor-components/confirm-dialog/confirm-dialog.js
Outdated
Show resolved
Hide resolved
assets/blocks/editor-components/confirm-dialog/confirm-dialog.js
Outdated
Show resolved
Hide resolved
| onConfirm, | ||
| onCancel, | ||
| } ) => { | ||
| useConfirmOnEnter( isOpen, onConfirm ); |
There was a problem hiding this comment.
Nice code separation here! 😀
| */ | ||
| import ConfirmDialog from './confirm-dialog'; | ||
|
|
||
| describe( '<ConfirmDialog />', () => { |
Co-authored-by: Renatho De Carli Rosa <renatho@gmail.com>
…o add/confirm-dialog
renatho
previously approved these changes
Jul 19, 2022
There was a problem hiding this comment.
The changes look great to me!
I just added a small comment about the hook, but I'm already approving it in case you don't agree.
About the styles, maybe we could merge it and tweak the styles in another PR. Unless you really prefer to wait and fix the styles before merging it. 😉
assets/blocks/editor-components/confirm-dialog/use-confirm-dialog-props.js
Outdated
Show resolved
Hide resolved
… to ConfirmDialog
Inspired by the Gutenberg's experimental Confirm Dialog component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
confirm()native function;Testing instructions
Check "Testing Instructions" on the PR 1537-gh-Automattic/sensei-pro