Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable _lesson_preview show-in-rest meta settings #5369

Merged
merged 1 commit into from Jul 21, 2022

Conversation

onubrooks
Copy link
Contributor

Fixes #

Changes proposed in this Pull Request

  • Adds settings to show lesson_preview post meta in the lessons REST API.

Testing instructions

  • The easiest way to test this is in the block editor using the following snippet:
    useSelect(() => { return select('core/editor').getCurrentPostAttribute( 'meta' ); })

  • Ensure _lesson_preview key is present in the object returned.

@onubrooks onubrooks requested a review from a team July 20, 2022 15:35
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #5369 (089de58) into trunk (5fe92a8) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk    #5369      +/-   ##
============================================
- Coverage     40.82%   40.81%   -0.01%     
  Complexity     8639     8639              
============================================
  Files           285      285              
  Lines         29127    29133       +6     
============================================
  Hits          11891    11891              
- Misses        17236    17242       +6     
Impacted Files Coverage Δ
...t-api/class-sensei-rest-api-lessons-controller.php 9.83% <0.00%> (-1.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37cc8aa...089de58. Read the comment docs.

@onubrooks onubrooks merged commit 2278ea1 into trunk Jul 21, 2022
@onubrooks onubrooks deleted the add/lesson-preview-rest-api branch July 21, 2022 12:31
@gikaragia gikaragia added this to the 4.6.0 milestone Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants