From d080f6d0f2894262895f60993ecb059b005523e9 Mon Sep 17 00:00:00 2001 From: Imran Hossain Date: Mon, 1 Apr 2024 17:41:19 +0600 Subject: [PATCH 1/6] Deprecate sell with woocommerce task --- .../class-sensei-home-task-sell-course-with-woocommerce.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/includes/admin/home/tasks/task/class-sensei-home-task-sell-course-with-woocommerce.php b/includes/admin/home/tasks/task/class-sensei-home-task-sell-course-with-woocommerce.php index caf274748e..ce6ad50fe2 100644 --- a/includes/admin/home/tasks/task/class-sensei-home-task-sell-course-with-woocommerce.php +++ b/includes/admin/home/tasks/task/class-sensei-home-task-sell-course-with-woocommerce.php @@ -9,6 +9,8 @@ /** * Sensei_Home_Task_Sell_Course_With_WooCommerce class. * + * @deprecated $$next-version$$ We're now showing the "Sell your course with Sensei Pro" (Sensei_Home_Task_Pro_Upsell) task instead of this task. + * * @since 4.8.0 */ class Sensei_Home_Task_Sell_Course_With_WooCommerce implements Sensei_Home_Task { From af71e71507a53651fe4bf2383f537a063469ff02 Mon Sep 17 00:00:00 2001 From: Imran Hossain Date: Mon, 1 Apr 2024 17:41:42 +0600 Subject: [PATCH 2/6] Remove call to Sell with WooCommerce task --- .../admin/home/tasks/class-sensei-home-tasks-provider.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/includes/admin/home/tasks/class-sensei-home-tasks-provider.php b/includes/admin/home/tasks/class-sensei-home-tasks-provider.php index 74fdeba8cf..fcfc619fe5 100644 --- a/includes/admin/home/tasks/class-sensei-home-tasks-provider.php +++ b/includes/admin/home/tasks/class-sensei-home-tasks-provider.php @@ -67,10 +67,6 @@ private function get_tasks(): array { new Sensei_Home_Task_Publish_First_Course(), ]; - if ( Sensei_Home_Task_Sell_Course_With_WooCommerce::is_active() ) { - $core_tasks[] = new Sensei_Home_Task_Sell_Course_With_WooCommerce(); - } - if ( Sensei_Home_Task_Pro_Upsell::is_active() ) { $core_tasks[] = new Sensei_Home_Task_Pro_Upsell(); } From b26fe07e31dd591b88b4001337164f94246f416c Mon Sep 17 00:00:00 2001 From: Imran Hossain Date: Mon, 1 Apr 2024 17:44:10 +0600 Subject: [PATCH 3/6] Add changelog --- changelog/add-deprecate-sell-course-wth-woocommerce-task | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 changelog/add-deprecate-sell-course-wth-woocommerce-task diff --git a/changelog/add-deprecate-sell-course-wth-woocommerce-task b/changelog/add-deprecate-sell-course-wth-woocommerce-task new file mode 100644 index 0000000000..ec22569c54 --- /dev/null +++ b/changelog/add-deprecate-sell-course-wth-woocommerce-task @@ -0,0 +1,4 @@ +Significance: minor +Type: deprecated + +Remove Sell your course with WooCommerce task from core From f1584310c3a05815eff0e117d710c8af03533e34 Mon Sep 17 00:00:00 2001 From: Imran Hossain Date: Mon, 1 Apr 2024 19:04:36 +0600 Subject: [PATCH 4/6] Remove function to monitor sell with woo task --- includes/class-sensei-admin.php | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/includes/class-sensei-admin.php b/includes/class-sensei-admin.php index 0b6e6c040e..e40d2a4d4d 100755 --- a/includes/class-sensei-admin.php +++ b/includes/class-sensei-admin.php @@ -55,7 +55,6 @@ public function __construct() { add_action( 'menu_order', array( $this, 'admin_menu_order' ) ); add_action( 'admin_head', array( $this, 'admin_menu_highlight' ) ); add_action( 'admin_init', array( $this, 'sensei_add_custom_menu_items' ) ); - add_action( 'admin_init', array( $this, 'admin_init' ) ); add_action( 'admin_print_scripts', array( $this, 'sensei_set_plugin_url' ) ); // Duplicate lesson & courses @@ -1595,24 +1594,6 @@ function( $item ) use ( $type ) { return $course_structure; } - /** - * Registers the hook to call mark_completed on tasks that have been - * completed. - * - * @access private - * @return void - */ - public function admin_init() { - global $pagenow; - - if ( Sensei_Home_Task_Sell_Course_With_WooCommerce::is_active() ) { - $hook = get_plugin_page_hook( 'wc-admin', 'woocommerce' ); - if ( null !== $hook ) { - add_action( $hook, [ Sensei_Home_Task_Sell_Course_With_WooCommerce::class, 'mark_completed' ] ); - } - } - } - function sensei_add_custom_menu_items() { global $pagenow; From 9ac6dca619283f2465943f3ef720f2f069e950cd Mon Sep 17 00:00:00 2001 From: Imran Hossain Date: Tue, 2 Apr 2024 14:56:21 +0600 Subject: [PATCH 5/6] Deprecate in constructor --- ...-sensei-home-task-sell-course-with-woocommerce.php | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/includes/admin/home/tasks/task/class-sensei-home-task-sell-course-with-woocommerce.php b/includes/admin/home/tasks/task/class-sensei-home-task-sell-course-with-woocommerce.php index ce6ad50fe2..0784a64751 100644 --- a/includes/admin/home/tasks/task/class-sensei-home-task-sell-course-with-woocommerce.php +++ b/includes/admin/home/tasks/task/class-sensei-home-task-sell-course-with-woocommerce.php @@ -16,6 +16,17 @@ class Sensei_Home_Task_Sell_Course_With_WooCommerce implements Sensei_Home_Task { const VISITED_WOOCOMMERCE_ADMIN_OPTION_KEY = 'sensei_home_task_visited_woocommerce'; + /** + * Class constructor. + */ + public function __construct() { + if ( is_wp_version_compatible( '6.4' ) ) { + _deprecated_class( __CLASS__, '$$next-version$$', 'Sensei_Home_Task_Pro_Upsell' ); + } else { + _deprecated_function( __METHOD__, '$$next-version$$', 'Sensei_Home_Task_Pro_Upsell' ); + } + } + /** * The ID for the task. * From dc1a4ac10f6a359ada1108a1d201c75f66ee3b59 Mon Sep 17 00:00:00 2001 From: Imran Hossain Date: Tue, 2 Apr 2024 15:20:22 +0600 Subject: [PATCH 6/6] Update deprecation message --- .../class-sensei-home-task-sell-course-with-woocommerce.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/admin/home/tasks/task/class-sensei-home-task-sell-course-with-woocommerce.php b/includes/admin/home/tasks/task/class-sensei-home-task-sell-course-with-woocommerce.php index 0784a64751..5b25888347 100644 --- a/includes/admin/home/tasks/task/class-sensei-home-task-sell-course-with-woocommerce.php +++ b/includes/admin/home/tasks/task/class-sensei-home-task-sell-course-with-woocommerce.php @@ -23,7 +23,7 @@ public function __construct() { if ( is_wp_version_compatible( '6.4' ) ) { _deprecated_class( __CLASS__, '$$next-version$$', 'Sensei_Home_Task_Pro_Upsell' ); } else { - _deprecated_function( __METHOD__, '$$next-version$$', 'Sensei_Home_Task_Pro_Upsell' ); + _deprecated_function( __METHOD__, '$$next-version$$', 'Sensei_Home_Task_Pro_Upsell::__construct' ); } }