Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify last used monitor availability when restoring window position #1176

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
2 participants
@mirka
Copy link
Member

commented Jan 25, 2019

Closes #592

electron-window-state (the module we are using to persist window position after quit) had not been checking whether a last used external monitor had been disconnected. So if Simplenote was last positioned on an external monitor that is now disconnected, the Simplenote window would be unrecoverable.

To test

I tested this on an actual Windows machine, since I couldn't reproduce the original issue on a Mac.

Note: To reproduce the original issue, your external display must be configured to be on the LEFT of your main display.

  1. Launch the app and move the window to an external display.
  2. Quit the app.
  3. Disconnect the external display.
  4. Relaunch the app.

The app window should be visible on the main screen.

@mirka mirka changed the title [WIP] Verify last used monitor availability when restoring window position Verify last used monitor availability when restoring window position Jan 28, 2019

@mirka mirka requested a review from roundhill Jan 28, 2019

@roundhill
Copy link
Member

left a comment

Tested the appx build on this PR and verified fixed :shipit:

@mirka mirka merged commit 6102526 into master Jan 31, 2019

5 checks passed

ci/circleci: artifacts Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: linux Your tests passed on CircleCI!
Details
ci/circleci: mac Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details

@mirka mirka deleted the update/electron-window-state branch Jan 31, 2019

mirka added a commit that referenced this pull request Feb 6, 2019

mirka added a commit that referenced this pull request Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.