New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore: Add e2e-testing with Spectron #1773
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Seems like a great start. Not sure what kind of review you want at this point but I'll approve to say the code looks good and it works.
Thanks @codebykat - were you able to get the tests to run on your computer? I think I'd like to let this sit for another day or two and give people the chance to comment, but after that I'd like to get it merged even with all its shortcomings so that we can start. I'm thinking that for now we don't need to have these automated as it would suffice for now if we had an end-to-end test suite to run it locally as a verification step before making a release. That could save us considerable headache. |
This is causing CI to fail. Once that is resolved ping me for a review. |
The tests did run for me, yes. |
When I get back around to this I'd like to move the e2e testing out of CI for now and let it be a manual process. We can iterate on it later and taking it out of the automated tests is surely going to make it easier in the beginning. |
Sounds good! |
2732d51
to
25e66e7
Compare
In this patch we're creating the most basic form of end-to-end testing using the Spectron framework. This boots the app and verifies that it opens. The files aren't in the right spot and the structure of the tests need to change but this gives us an idea of how to run these tests.
28b040f
to
0b1a1bc
Compare
In this patch we're creating the most basic form of end-to-end testing
using the Spectron framework. This boots the app and verifies that it
opens.
The files aren't in the right spot and the structure of the tests need
to change but this gives us an idea of how to run these tests.
Testing
Checkout this branch and run the tests setting the username/password
for some test account.
You should see the app appear and the credentials entered automatically
into the login form.
Notes
Links