Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for importing .md files #2351

Merged
merged 5 commits into from Sep 23, 2020
Merged

Conversation

belcherj
Copy link
Contributor

@belcherj belcherj commented Sep 22, 2020

Fix

Fixes: #2155

Adds support for .md files. Since they are basically plaintext files we can import them using the plaintext editor.

Screen Shot 2020-09-22 at 3 24 20 PM

Test

  1. Test importing markdown files
  2. Test importing plain text files.

@belcherj belcherj requested a review from a team September 22, 2020 19:02
@belcherj belcherj self-assigned this Sep 22, 2020
@codebykat codebykat self-requested a review September 22, 2020 22:35
Copy link
Member

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked great.

I have two tiny nits:

  1. I think we should default the "enable Markdown" checkbox to checked when a .md file is selected:

Screen Shot 2020-09-22 at 3 34 42 PM

  1. The change in line length makes this line break awkwardly:

Screen Shot 2020-09-22 at 3 34 07 PM

Maybe we can remove the word "plain" or make the line longer by saying "plain-text or Markdown-formatted files":

Screen Shot 2020-09-22 at 3 38 24 PM

Screen Shot 2020-09-22 at 3 39 12 PM

I'm now feeling uncertain if it should be "plain-text" or "plain text" 🤷‍♀️

@belcherj
Copy link
Contributor Author

I changed the text to read Choose one or more text files (.txt, .md)

@belcherj
Copy link
Contributor Author

I think we should default the "enable Markdown" checkbox to checked when a .md file is selected

There is a bit of complexity in doing this. I don't think the benefit is worth the cruft it adds. I think we should tackle that when we refactor settings as part of spring cleaning.

@codebykat
Copy link
Member

It seems quite silly to not default to setting Markdown on a Markdown file, but it's not a hill I'm choosing to die on today.

@belcherj belcherj merged commit 5b74af1 into develop Sep 23, 2020
@belcherj belcherj deleted the add/markdown-import-support branch September 23, 2020 00:54
@belcherj belcherj mentioned this pull request Sep 23, 2020
@codebykat codebykat added this to the 2.0.0 milestone Oct 5, 2020
@codebykat codebykat mentioned this pull request Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support .md format on 'Import Notes...' Dialog
3 participants