New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for importing .md files #2351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked great.
I have two tiny nits:
- I think we should default the "enable Markdown" checkbox to checked when a .md file is selected:
- The change in line length makes this line break awkwardly:
Maybe we can remove the word "plain" or make the line longer by saying "plain-text or Markdown-formatted files":
I'm now feeling uncertain if it should be "plain-text" or "plain text" 🤷♀️
I changed the text to read |
There is a bit of complexity in doing this. I don't think the benefit is worth the cruft it adds. I think we should tackle that when we refactor settings as part of spring cleaning. |
It seems quite silly to not default to setting Markdown on a Markdown file, but it's not a hill I'm choosing to die on today. |
Fix
Fixes: #2155
Adds support for .md files. Since they are basically plaintext files we can import them using the plaintext editor.
Test