Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fixes #458 #385 #276

Merged
merged 1 commit into from

3 participants

Arnout Kazemier Ivan Lukashov Guillermo Rauch
Arnout Kazemier

They are reported in learnboost/socket.io

This causes a StackOverflow in IE8

Ivan Lukashov

it did not help, still get stack overflow in IE8

Arnout Kazemier

@webstalk3r

Thats why I said a instead of the as there are multiple spots where this might ocurre

Ivan Lukashov

Ok, any advices?
Disable XHR/IE8 connection for a while?

Guillermo Rauch rauchg merged commit 1771590 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 11, 2011
  1. Arnout Kazemier

    Fixes #458 #385

    3rd-Eden authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/transports/xhr.js
2  lib/transports/xhr.js
View
@@ -149,7 +149,7 @@
XHR.prototype.request = function (method) {
var req = io.util.request(this.socket.isXDomain())
- , query = io.util.query(this.socket.options.query, + 't=' + +new Date);
+ , query = io.util.query(this.socket.options.query, 't=' + +new Date);
req.open(method || 'GET', this.prepareUrl() + query, true);
Something went wrong with that request. Please try again.