Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

hiredis requirement causes build issues on Windows #978

Closed
lperrin opened this Issue · 3 comments

3 participants

@lperrin

the build script of hiredis requires GNU make, which is rarely present on Windows systems.

I understand that redis is a supported storage engine by socket.io, but it doesn't seem like a core feature to me and having it as a mandatory requirement seems a bit abusive to me.

Is it possible to remove the requirement from package.json and instead print a warning if the user tries to use redis storage without hiredis installed ?

I can write a patch if needed.

@rauchg
Owner

Seems like a bug in the redis package, as hiredis shouldn't be mandatory.

@lassikin

It seems to work regardless of npm making warnings(redisstore on windows).

@lperrin

It seems that it's indeed not a problem with socket.io, closing the issue.

@lperrin lperrin closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.