Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.7.0 -- changed to 3.6.2 #237

Closed
wants to merge 4 commits into from
Closed

Release 3.7.0 -- changed to 3.6.2 #237

wants to merge 4 commits into from

Conversation

aaronfc
Copy link
Contributor

@aaronfc aaronfc commented May 16, 2022

Release 3.7.0

@aaronfc aaronfc requested a review from a team May 16, 2022 12:10
@@ -2,9 +2,9 @@
Contributors: Viper007Bond, automattic, donncha
Donate link: https://alex.blog/2019/03/13/in-memory-of-alex-donation-link-update/
Tags: code, source, sourcecode, php, syntax highlighting, syntax, highlight, highlighting, highlighter, WordPress.com
Requires at least: 5.6
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I increased this to follow the L-2 window we are following in other plugins. Any opinions on this?

Copy link
Contributor

@alexsanford alexsanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a comment below regarding the version number. But otherwise I think it's good to go!

@@ -40,6 +40,10 @@ Try excluding this plugin's Javascript from any performance optimizations your s

== ChangeLog ==

= Version 3.7.0 =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should be 3.6.2 instead? Just looking at the pattern below, I think if we're only adding a new language we should consider it a "patch" rather than a "minor".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see much consistency and decided on doing a minor for languages. But I am ok doing a patch for this, given that is a fairly small release compared to previous ones.

@aaronfc
Copy link
Contributor Author

aaronfc commented May 16, 2022

Closed and replaced with this one: #238

@aaronfc aaronfc closed this May 16, 2022
@aaronfc aaronfc changed the title Release 3.7.0 Release 3.7.0 -- changed to 3.6.2 May 16, 2022
@aaronfc aaronfc deleted the release/3.7.0 branch May 16, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants