Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Jul 24, 2015
  1. @schwuk

    Handle `SubscriptionModule` being disabled

    schwuk committed
    Only fire `subscription.fetch()` if `subscriptionView` has been bound to
    an element.
Commits on Jul 14, 2015
  1. @schwuk

    Merge pull request #57 from schwuk/fix_56_url_not_found

    schwuk committed
    Fixes #56 by not hardcoding the `subscription` URL
Commits on Jul 13, 2015
  1. @schwuk
Commits on Apr 11, 2015
  1. @schwuk

    Merge pull request #45 from schwuk/subscriptions-ui

    schwuk committed
    Add (minimal) UI for subscriptions
Commits on Oct 3, 2014
  1. @schwuk

    Fixed #48 by including text template files

    schwuk committed
    Explicity include text template files - used by email notifications - in
  2. @schwuk

    Fix indentation.

    schwuk committed
  3. @schwuk

    Replaced 404 response with 204 (empty)

    schwuk committed
    For subscriptions that do not yet exist, return a 204 `NO CONTENT`
    response instead of a 404 `NOT FOUND`. Backbone handles empty reponses
    correctly, and the 204 code will not trigger a jQuery `ajaxError` event.
  4. @schwuk

    Added (minimal) UI for subscriptions

    schwuk committed
    Added `SubscriptionModule` to handle subscriptions views:
     * Inject a (disabled) button into `changeset`, `browser`, and
     `attachment` pages.
     * Handle `GET`, `POST`, and `PUT` requests for subscriptions, accepting
     and returning only JSON content
    Added `Subscription.for_request()` to get or create a subscription from
    a request.
    Added Backbone `Subscription` model and `SubscriptionView` view to
    handle UI interaction.
    Modified email template to let users know how to unsubscribe.
Commits on Sep 29, 2014
  1. @nb

    Remove the line-comment template

    nb committed
    Wasn’t used anywhere
  2. @nb
  3. @nb

    Move page-level comments to the bottom

    nb committed
    If they’re at the top and somebody goes to the page just to look at the
    file and not at the comments, a huge discussion at the top can be very
    We assume that people will go to pages more often to see the
    files/diffs/commits than to look at comments.
  4. @nb

    Visual improvements of comments display

    nb committed
    * Comments now start from the beginning of the row – helps with recognizing
    when comments start
    * Lighter colors
    * Paddings and margins have better harmony
    * Highlighted comments are using less harsh colors than yellow
  5. @nb

    Mock req when converting wiki to HTML

    nb committed
    Some parts of the conversion code tries to use permissions or other
    parts of the request, which aren’t always present (for example when we
    convert wiki text on the console)
Commits on Aug 22, 2014
  1. @nb

    Merge pull request #44 from schwuk/comment-subscriptions

    nb committed
    Extract comment subscriptions as their own module
Commits on Aug 20, 2014
  1. @schwuk

    Dropped `role` from `Subscription`

    schwuk committed
    Removed `role` attribute from `Subscription` as it was providing no
    real additional value.
    All notifications are now sent **to** subscribers, and no longer copied.
    Changed some `debug` logging to be `info`.
  2. @schwuk

    Address review comments #2

    schwuk committed
    Test for `basestring` instead of `str` and `unicode`.
    Clearer logging.
    Don't explicitly convert `Subscription` to a `str` for logging.
  3. @schwuk

    Address review points

    schwuk committed
    Re-capitalise SQL keywords.
    Improve `` to handle `unicode` values.
    Add `Susbcription.__str__()` to provide a string represention of a
    Refactor `Subscription._from_dict()` method to use `select()` as a
    single source for select queries and `__str__()` to improve logging.
Commits on Aug 15, 2014
  1. @schwuk

    Refactored `CodeCommentNotifyEmail` to use subscriptions

    schwuk committed
    Added a `for_comment` query helper.
    Changed the notification scheme so that resource authors **always**
    receive a "to" notification.
    Changed the `notify` column to be a boolean.
    Changed the `for_*` signatures to accept an optional `notify` flag.
    Changed the `select` signature to accept an optional `notify` flag, and
    the method to include the flag in the query.
    Changed the `select` method to handle `dict`, `list, and `bool` query
  2. @schwuk

    Flesh out `Subscription` model methods

    schwuk committed
    Added `select`, `update`, and `delete` methods to `Subscription` to handle all
    CRUD operations.
    Changed the signatures on `from_attachment`, `from_changeset`, and
    `from_comment` to let the `user`, `role`, and `notify` values be overridden.
    Added `for_attachment` and `for_changeset` methods to shortcut queries for
    those resource types.
    Added `attachment_deleted`, `attachment_reparented`, and `changeset_modified`
    event handlers.
  3. @schwuk
Commits on Aug 14, 2014
  1. @schwuk

    Added `from_attachment()` method

    schwuk committed
    Use Attachment objects instead of manually querying the database. (We
    still need the initial manual query as there's no way to get all
  2. @schwuk

    Add model for Subscription

    schwuk committed
  3. @schwuk

    Added trac-admin command to seed subscriptions

    schwuk committed
    Circular dependencies prevented the database upgrade from _nicely_
    handling the creation of subscriptions for existing resources, so all
    logic and code has been moved to a new `subscription` module. Various
    routines for creating subscriptions have been extracted into standalone
    methods, and the code refactored to use objects instead of direct
    database queries.
  4. @schwuk

    Populate subscriptions for existing comments

    schwuk committed
    Create subscriptions for attachments and revisions using helper
    Added `notify` column to flag subscriptions as active (always) or inactive (never)
    Added id column to subscription table
    Changed column `usertype` to `role`
Commits on Aug 9, 2014
  1. @schwuk

    Schema for subscriptions

    schwuk committed
    Create table for subscriptions.
    Populate table with subscriptions for attachments and revisions.
    Subscriptions will support multiple repositories and Git, even though
    code comments themselves don't currently (#13 and #14).
Commits on Aug 7, 2014
  1. @schwuk

    Added todo list.

    schwuk committed
  2. @nb

    Merge pull request #42 from schwuk/notifications

    nb committed
    Send notifications when comments are created
    For now send them only to other participants of the thread, but this builds some infrastructure for sending them to more users.
  3. @schwuk
  4. @schwuk
  5. @schwuk
  6. @schwuk
  7. @schwuk
  8. @schwuk
  9. @schwuk
  10. @schwuk

    Override NotifyEmail.send() so we can provide the from_name

    schwuk committed
    No more swapping around of config values.
Something went wrong with that request. Please try again.