Skip to content
Commits on Aug 7, 2014
  1. @schwuk
  2. @schwuk

    Added notifications to README.

    schwuk committed Aug 1, 2014
  3. @schwuk
  4. @schwuk

    Send notifications when comments are created

    Added a new interface - ICodeCommentChangeListener - to use for
    Added a new component - CodeCommentSystem - to act as the extension
    point for the above interface. (This could have been added to one of the
    other components, but I have plans for other refactorings and wanted a
    clean base for them.)
    Extended Comments.create() to trigger comment_created events.
    Added a new component - CodeCommentChangeListener - to respond to
    comment_created events.
    Sub-classed trac.notification.NotifyEmail to generate notification
    emails. Notifications are sent to the author of the resouce being
    commented on, and anyone else who has commented on the same resource.
    There is additional logic to determine who the notification should be
    *sent* and *copied* to.
    Added an option to control whether notifications are sent to the person
    making the comment (off by default).
    Removed unused variable.
    schwuk committed Aug 1, 2014
  5. @nb

    Merge pull request #41 from schwuk/comments_for_directories

    Comments for directories
    nb committed Aug 7, 2014
Commits on Aug 4, 2014
  1. @schwuk
  2. @schwuk

    Allow adding comments to directories in the code browser

    Fixes #39.
    Due to a different table id, top comments were not shown for directories
    in the code browser. Change the `selectorToInsertBefore` to support both
    files and directories.
    The code browser supports keyboard shortcuts for navigating directories
    which conflict with the add comment dialog, so now any keypresses within
    the dialog will not be propagated to avoid this. Made the dialog modal
    to reflect this.
    Add whitespace to selector list.
    schwuk committed Jul 27, 2014
  3. @nb

    Merge pull request #40 from schwuk/upgrade_js_libraries

    Upgrade JavaScript libraries
    nb committed Aug 4, 2014
Commits on Jul 25, 2014
  1. @schwuk
  2. @schwuk

    Updated json2.js

    schwuk committed Jul 25, 2014
  3. @schwuk

    Updated Backbone and Underscore libraries

    Updated Backbone.js to 1.1.2, and ensures collection.create waits for
    response before updating the view.
    Updated Underscore to 1.6.0, ensuring noConflict is used to avoid
    conflict with babel.js.
    schwuk committed Jul 25, 2014
Commits on Jul 24, 2014
  1. @schwuk

    Updated jQuery and jQuery UI

    Updated jQuery to 1.11.1.
    Updated jQuery UI to 1.11.0 and created new theme based on existing one.
    schwuk committed Jul 24, 2014
Commits on Mar 1, 2014
  1. @nb

    Simplify the mouse out handler

    We can assume the `this` is the row. From my testing it’s always true.
    nb committed Mar 2, 2014
  2. @nb

    Add RowView

    Represents a single row and here we will keep all the operations
    related to it: extracting file/line data, manipulating cells.
    nb committed Mar 2, 2014
  3. @nb

    Only add new comments to the current list

    In 58c9df7 we didn’t translate the code correctly and we were adding
    all comments to all sections on the page.
    nb committed Mar 2, 2014
  4. @nb
  5. @nb

    Add RowsView

    It represents all the rows with code on the page.
    Since we have few operations over rows, it sounds logical to extract
    them in a separate view. The main element is all the tables.
    nb committed Mar 2, 2014
  6. @nb

    Set CommentsPerLineView.line in the constructor

    Before it was set when the first comment was added, but we know the line
    at creation, so it’s cleaner to set it then.
    nb committed Mar 1, 2014
  7. @nb

    Set path of the dialog view on open

    Before we were setting it in the buildDialogTitle() method, which wasn't
    very intuitive.
    nb committed Mar 1, 2014
  8. @nb

    Switch to query-specific collection methods

    This way it the purpose of the fetch calls is clearer.
    nb committed Mar 1, 2014
  9. @nb

    Ignore local deploy script

    nb committed Oct 10, 2013
  10. @nb

    Introduce CommentView.appendTo()

    To be able to scroll to the active comment we need to know when
    a comment is added to the DOM. Since we have more than one case and we
    don't want to repeat ourselves, we inverted the responsibility and now
    the `appendTo()` method takes care of adding a comment to the DOM and
    also scrolls down if needed.
    nb committed Mar 1, 2014
  11. @nb

    Use instead of CodeComments.type

    There was no attribute type, because we only set the page when we pass
    data from the backend to the frontend.
    nb committed Mar 1, 2014
  12. @nb

    Merge pull request #32 from codebykat/changeset-comments

    Add line-level comments on changesets
    nb committed Mar 1, 2014
  13. @codebykat

    Add fetchComments function to abstract parameters to fetch()

    Views shouldn't have to care about fetch() parameters, so this abstracts the fetch() call into the model.
    The CommentsList model now provides a fetchComments() function.  Its optional argument, commentsToFetch, defaults to top-level comments but can be set to 'line' to request inline comments instead.
    codebykat committed Feb 28, 2014
  14. @codebykat
Commits on Feb 28, 2014
  1. @codebykat

    Check self.line instead of self.path

    Now the condition makes more sense and we don't need the comments.
    codebykat committed Feb 27, 2014
Commits on Feb 27, 2014
  1. @codebykat

    Change 'page' column to 'type'

    The 'type' column defines whether the comment was made on a file, changeset or attachment.
    codebykat committed Feb 27, 2014
  2. @codebykat

    Fixes a bug where Add Comment buttons kept focus

    This caused them to stay gray after being clicked, even after the Add Comment dialog box was closed or a comment was successfully added.
    Also removes the manual call to 'close', which was never being used (jQueryUI takes care of the close button itself).
    codebykat committed Feb 27, 2014
  3. @codebykat

    Refactor to share $tableRows variable between views, use method to bu…

    …ild dialog box title
    * Instead of redeclaring $tableRows inside a view, stash it in CodeComments so all the views can access it.
    * Use buildDialogTitle to construct the title of the "Add comment" dialog box.
    * Fix a bug where the dialog box wasn't getting the correct title if "Reply" was clicked on a line comment.
    * Removed "TODO: + links" comment which probably applied to anchor links.
    codebykat committed Feb 27, 2014
  4. @codebykat

    Use .complete() to jump to comment anchor after comments have all bee…

    …n rendered
    * In order to get AJAX .complete(), we need to upgrade to jQuery 1.5, so we use noConflict() to return control to Trac's packaged jQuery 1.4.4.  This avoids breaking Trac's JS.
    * Still need a small timeout in order for the results of .offset() to be always correct -- presumably because the browser needs to finish rendering DOM changes.  But at least we know we *have* all the data by then.
    * Removed the hash from the URL, instead using the existing CodeComment.active_comment_id.  Semantically it would make more sense to change the code_comment parameter to a hash, but we'd want to do that everywhere if we do.
    * Renamed comment div IDs from e.g. C13 to comment-13; more readable and less likely to conflict with anything else on the page.  Removed "name" attribute for now since we're not using real anchors.
    codebykat committed Feb 27, 2014
Commits on Feb 17, 2014
  1. @codebykat
Commits on Feb 9, 2014
  1. @codebykat

    Hack to get anchors to comments working for changeset view

    Just adding new anchors and permalinks isn't good enough; the Backbone view hasn't rendered the comments yet, so jumping to the anchor fails.
    This is a hack that hooks up to _.defer and uses a setTimeout, because even _.defer is not waiting long enough to make sure the DOM has rendered before it runs.
    codebykat committed Feb 9, 2014
  2. @codebykat
  3. @codebykat
Something went wrong with that request. Please try again.