Code Comments from main menu do not work #2

mumpitzstuff opened this Issue Feb 6, 2012 · 0 comments

2 participants


If i click on Code Comments within the main menu, my browser tries to open https://myserver/my/trac/code-comments/preview which is always empty. I think it should open a list of comments or something like that?

@nb nb added a commit that closed this issue Feb 6, 2012
@nb nb Don't run the INavigationContributor methods on every component
Since the base component implemented INavigationContributor, the
methods were called for each of its children too. But it uses
`self.href`, which may be different for every child.

Thus, in the main navigation the link was leading to the preview link,
not to the main code-comments one.

Fixes #2
@nb nb closed this in 33edcd0 Feb 6, 2012
@codebykat codebykat referenced this issue in codebykat/trac-code-comments-plugin Jan 18, 2014
@pepegar pepegar Fixes a bug whereby the comments in green lines are not displayed.
solves #2.
@schwuk schwuk added a commit to schwuk/trac-code-comments-plugin that referenced this issue Aug 20, 2014
@schwuk schwuk Address review comments #2
Test for `basestring` instead of `str` and `unicode`.

Clearer logging.

Don't explicitly convert `Subscription` to a `str` for logging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment