Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track version and OS #152

Closed
simonwheatley opened this issue Jul 20, 2018 · 1 comment · Fixed by #172
Closed

Track version and OS #152

simonwheatley opened this issue Jul 20, 2018 · 1 comment · Fixed by #172
Assignees
Milestone

Comments

@simonwheatley
Copy link
Contributor

Currently we bundle the version and the OS into the User Agent string, for tracking purposes. To help us understand the environment of our installed userbase, we should track the CLI version and the user OS separately.

Perhaps put the OS in browserplatform and the version in browserfamilyversion?

@mjangda
Copy link
Member

mjangda commented Jul 24, 2018

Will need to look into the innards of Tracks to see how it handles these properties (i.e. are they accepted as-is if passed in or are they generated?)

@mjangda mjangda self-assigned this Jul 31, 2018
@mjangda mjangda added this to the 1.2.0 milestone Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants