Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Puts the component classname on the root element #193

Merged
merged 1 commit into from Mar 13, 2023

Conversation

brunobasto
Copy link
Contributor

Description

On a previous PR, I added a div element around the table component to allow for horizontal scrolling. Doing that made some E2E tests break because the root element of that component no longer a table. This PR makes the root element have the component class. Additional changes must also be made on the E2E tests as to not use > table selector directly and instead use the component class name: > .vip-table-component.

Checklist

  • This PR has good automated test coverage
  • The storybook for the component has been updated

Steps to Test

  1. Pull down PR.
  2. npm run dev.
  3. Open Storybook.
  4. Open the Table example
  5. Inspect the DOM and verify the table parent div has the vip-component-table class.

@netlify
Copy link

netlify bot commented Mar 10, 2023

Deploy Preview for vip-design-system-components ready!

Name Link
🔨 Latest commit ff517d4
🔍 Latest deploy log https://app.netlify.com/sites/vip-design-system-components/deploys/640b7a4979d1e10008271770
😎 Deploy Preview https://deploy-preview-193--vip-design-system-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@djalmaaraujo djalmaaraujo merged commit 01eebf8 into trunk Mar 13, 2023
5 checks passed
@djalmaaraujo djalmaaraujo deleted the fix/table-component-classname branch March 13, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants