Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP_Filesystem_VIP blocks local core upgrades #1054

Closed
mjangda opened this issue Dec 26, 2018 · 6 comments

Comments

Projects
None yet
6 participants
@mjangda
Copy link
Member

commented Dec 26, 2018

This can be pretty annoying to work around:

$ wp core update
Updating to version 5.0.2 (en_US)...
Using cached file '/home/vagrant/.wp-cli/cache/core/wordpress-5.0.2-new-bundled-en_US.zip'...
Unpacking the update...
Warning: The `/vagrant/www/wordpress-default/public_html/wp-content/upgrade/wp_5c23bc476bff2` file cannot be managed by the `Automattic\VIP\Files\WP_Filesystem_VIP` class. Writes are only allowed for the `/uploads` and `/tmp` directories and reads can be performed everywhere. in /vagrant/www/wordpress-default/public_html/wp-content/mu-plugins/files/class-wp-filesystem-vip.php on line 59
Warning: The `/vagrant/www/wordpress-default/public_html/wp-content/upgrade/wp_5c23bc476bff2` file cannot be managed by the `Automattic\VIP\Files\WP_Filesystem_VIP` class. Writes are only allowed for the `/uploads` and `/tmp` directories and reads can be performed everywhere. in /vagrant/www/wordpress-default/public_html/wp-content/mu-plugins/files/class-wp-filesystem-vip.php on line 59
Error: Could not create directory.
@cameronterry

This comment has been minimized.

Copy link

commented Jan 14, 2019

For any one who stumbles upon this in the meantime; as a very temporary workaround, you can add return; to the a8c-files.php file here after the two comment blocks to temporarily disable VIP Filesystem;

After this, you can use the WP CLI to perform Core, plugin, and theme updates.

@schlessera

This comment has been minimized.

Copy link

commented Mar 4, 2019

@mjangda I saw you were one of the original developers of the stream wrapper functionality that introduced this changes that is breaking WP-CLI behavior.

I'm the maintainer of WP-CLI and am interested in discussing a solution for this. Let me know if this requires changes in WP-CLI for a work-around.

@mjangda

This comment has been minimized.

Copy link
Member Author

commented Mar 5, 2019

Thanks @schlessera for the offer to help!

This is a bug in our implementation / environment setup so not something we should add a workaround for in WP-CLI.

@jonathanstegall

This comment has been minimized.

Copy link

commented Mar 10, 2019

I've been wondering if this is related: my local environment won't log anything in my wp-content/debug.log file, even when define( 'WP_DEBUG_LOG', true ); is present in wp-config.php. Adding the fix above doesn't change this behavior, but I wonder if anyone else has run into it?

@paulschreiber

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

Any update on this?

@hrkhal

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

Can progress be made on this? It's not ideal having to return early from an mu plugin to allow core upgrades in our local/testing envs.

@mjangda mjangda referenced this issue Mar 14, 2019

Merged

Make (Local) Core Upgrades Work Again #1185

1 of 1 task complete

@mjangda mjangda closed this in #1185 Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.